take min/max values instead of first/last of seq function #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the suggestion. I would prefer for users to use the existing solution, using option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
when assigning l$pos[[i]] inside smooth.twisst, seq function seemed to pick the chronological first and last values in pos.
However, some users may produce window_data_files with columns that are not sorted (mine was sorted 'naively' on command line, hence lexicographic sorting), and the error was caused by seq recieving values in which from < to.
Using instead the min/max values in the column can fix this,
data not being sorted causes further issues, for example with plot.twisst, so a more holistic solution may be better.
Cheers, thank you for this tool!