Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark SliceBuilder.addAll which expands dynamically #347

Open
simerplaha opened this issue Dec 15, 2021 · 0 comments
Open

Benchmark SliceBuilder.addAll which expands dynamically #347

simerplaha opened this issue Dec 15, 2021 · 0 comments
Labels
code cleanup Tasks that require general code improvements to improve readability production release Tasks required for production release

Comments

@simerplaha
Copy link
Owner

simerplaha commented Dec 15, 2021 •
edited

addAll is only needed in one location where expansion occurs rarely. Everything else know the exact or approximate minimum max size of the Slice to allocate.

This task is a reminder to add integration tests to assert this.
@simerplaha simerplaha added code cleanup Tasks that require general code improvements to improve readability production release Tasks required for production release labels Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanup Tasks that require general code improvements to improve readability production release Tasks required for production release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simerplaha