SubsitesVirtualPage contains overrides for non-standard fields

[davejtoews]

SubsitesVirtualPage defines the following fields:

• CustomMetaTitle
• CustomMetaKeywords

In an onBeforeWrite() call these values will save into:

• MetaTitle
• MetaKewords

Additionally the getCMSFields() call attempts to place these new fields next to the corresponding field they will override. The problem is, however, MetaTitle and MetaKeywords are not standard fields. They do not exist on VirtualPage or SiteTree and it cannot be assumed that they will exist in Page.

The result is fields that get dumped out at the bottom of the editor view, and which do not have the stated effect of overriding existing fields.

Is this a carryover from SilverStripe 3? An unstated dependency on another module which adds these fields?

[michalkleiner]

I think they used to be a part of CMS 3.x, then they got removed or moved to a module.
The MetaTitle can come from https://github.com/kinglozzer/silverstripe-metatitle, the MetaKeywords I can't find.

It's probably safe to say there should be a check for the existence of those fields.