Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archiving and restoring blocks can cause duplicate sort values #934

Open
ScopeyNZ opened this issue Sep 21, 2021 · 0 comments
Open

Archiving and restoring blocks can cause duplicate sort values #934

ScopeyNZ opened this issue Sep 21, 2021 · 0 comments

Comments

@ScopeyNZ
Copy link
Member

Currently when you archive a block, it's sort order is kept. If you then restore a block a bit later, after the set has been modified/re-arranged, then it's likely you'll have a conflict with the sort order number.

We should either;

  • Clear the existing sort order when elements are archived, and ensure the sort order is reset when restoring the block (like we do in BaseElement::onBeforeWrite already), or
  • Re-calculate the sort order when we restore a block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant