Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TopPage to use the standard dir structure #1021

Open
5 tasks
emteknetnz opened this issue Nov 14, 2022 · 0 comments
Open
5 tasks

Refactor TopPage to use the standard dir structure #1021

emteknetnz opened this issue Nov 14, 2022 · 0 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Nov 14, 2022

TopPage has a 'feature based' directory structure, which doesn't match anything else in Silverstripe core modules

image

While the argument can certainly be made that feature based dir structures are a better way to organise the code, it this context it's simply non-standard.

Acceptance criteria

  • Move the files in the TopPage dir to other standard locations
  • Update namespaces in moved files
  • Update referenced namespaces in config files
  • Appropriate classes are deprecated in CMS4, though wrapped in Deprecation::withNoReplacement() since the files aren't availabe until CMS5
  • Changelog is updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants