Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security warning is gone #1703

Closed
2 tasks done
ssmarco opened this issue Mar 7, 2024 · 2 comments
Closed
2 tasks done

Security warning is gone #1703

ssmarco opened this issue Mar 7, 2024 · 2 comments

Comments

@ssmarco
Copy link
Contributor

ssmarco commented Mar 7, 2024

Module version(s) affected

5.0.0

Description

The security warning that says, "Caution: Removing members from this list will remove them from all groups and the database". Is this something that be added back? See screenshot below.

image

How to reproduce

To reproduce, please login to the CMS and go to the Security section. From there, no warning is shown on the top of the list of users.

Possible Solution

No response

Additional Context

No response

Validations

  • Check that there isn't already an issue that reports the same bug
  • Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)
@GuySartorelli
Copy link
Member

Looks like an oversight from when SecurityAdmin was converted to be a ModelAdmin.
If you'd like to make a PR to add it back I'd be happy to review it, but the CMS Squad won't be prioritising this.

@GuySartorelli
Copy link
Member

As there hasn't been a PR raised for this, I'm going to close it. I think the nature of how deleting records in the CMS works is well established by this point, so we don't really need to warn people that deleting a user will delete the user.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants