Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CMSMenu controller routing rule when the controller is removed. #1599

Open
sabina-talipova opened this issue Oct 16, 2023 · 0 comments
Open

Remove CMSMenu controller routing rule when the controller is removed. #1599

sabina-talipova opened this issue Oct 16, 2023 · 0 comments
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 16, 2023 •
edited by GuySartorelli

Description

When CMSMenu::add_controller() is called a director rule is added, but it won't be removed when the controller is removed. We should implement a way to remove the routing rule when the controller is removed.

See:

silverstripe-admin/code/CMSMenu.php

Line 73 in 0f18b3d

* @todo A director rule is added when a controller link is added, but it won't be removed

This was referenced Oct 17, 2023
Closed
Merged
@GuySartorelli GuySartorelli changed the title TODO: Remove Director added rule when the item is removed Remove CMSMenu controller routing rule when the controller is removed. Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sabina-talipova