Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LeftAndMain.Panel.js - fix redraw order in togglePanel #1598

Open
sabina-talipova opened this issue Oct 16, 2023 · 2 comments
Open

LeftAndMain.Panel.js - fix redraw order in togglePanel #1598

sabina-talipova opened this issue Oct 16, 2023 · 2 comments

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 16, 2023

Description

Fix redraw order (inner to outer) in togglePanel, and re-enable silent flag to avoid multiple expensive redraws on a single load.
See:

// TODO Fix redraw order (inner to outer), and re-enable silent flag
// to avoid multiple expensive redraws on a single load.

@GuySartorelli
Copy link
Member

@sabina-talipova At first glance this sounds good (particularly "avoid multiple expensive redraws on a single load") - but I'm not sure what this issue is actually asking us to implment.
If you understand the context of the comment, can you please flesh out the issue a bit more with some context and additional information?
Otherwise, we should probably close it.

@sabina-talipova
Copy link
Contributor Author

Actually, I don't quite understand requirements of this TODO, but it seems to me that we should investigate possible issue mentioned in this comment. I would prefer to leave this ticket for a while and learn what happens, but don't spend too much time on it.

@GuySartorelli GuySartorelli changed the title TODO: LeftAndMain.Panel.js - fix redraw order in togglePanel LeftAndMain.Panel.js - fix redraw order in togglePanel Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants