Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: InputFields in Backend ignore ShopCurrency configuration #116

Open
MLindenhofer opened this issue Mar 6, 2024 · 0 comments

Comments

@MLindenhofer
Copy link

If there are configurations for ShopCurrency like this:

SilverShop\ORM\FieldType\ShopCurrency:
  decimal_delimiter: '.'
  thousand_delimiter: ','
  currency_symbol: '€'
  # european style currencies, e.g. 45,00 € instead of €45,00
  append_symbol: true

They will only affect the output in frontend. But in Backend the input still sticks with the default config with the english $ currency and the delimiters.

Example: Apply 5,10 for Specific Price with the config from above this will be converted and shown as 5.100 in Frontend because the comma is still evaluated as a thousands delimiter although . was defined for this in the config.

There is progress to improve internationalisation stuff in silvershop-core:
silvershop/silvershop-core#818 (comment)

Would be great if this module will also be improved :) to create a better experience for international e-commercers

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant