From cafdce9d8e3946a2f547187de5d70bcdbeb1a772 Mon Sep 17 00:00:00 2001 From: benjicarson <84831726+benjicarson@users.noreply.github.com> Date: Thu, 18 Nov 2021 10:55:19 +1300 Subject: [PATCH] fix: Resolve Calculator::getDiscountableAmount incongruity OrderItem::DiscountableAmount is on a per-unit basis, whereas Calculator::getDiscountableAmount relies on an OrderItem::Total equivalent value. --- src/Calculator.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Calculator.php b/src/Calculator.php index 4e8004a..c04a36a 100644 --- a/src/Calculator.php +++ b/src/Calculator.php @@ -168,7 +168,7 @@ protected function getDiscountableAmount($discount) foreach ($this->order->Items() as $item) { if (ItemDiscountConstraint::match($item, $discount)) { $amount += $item->hasMethod('DiscountableAmount') ? - $item->DiscountableAmount() : + $item->DiscountableAmount() * $item->Quantity : $item->Total(); } }