Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create an archive with multiple recordings #11

Open
jhazentia opened this issue Apr 19, 2023 · 2 comments · May be fixed by #21
Open

Unable to create an archive with multiple recordings #11

jhazentia opened this issue Apr 19, 2023 · 2 comments · May be fixed by #21

Comments

@jhazentia
Copy link

There does not appear to be a way to create an archive from a collection or with multiple recordings.

I am planning to work on this and submit a PR.

@jacobagilbert
Copy link
Member

Hi @jhazentia thanks for getting involved here.

@gmabey as our resident archive poweruser, do you have any insights for this?

@gmabey
Copy link
Contributor

gmabey commented Apr 27, 2023

Sorry for the delay in responding.

It definitely looks like you're right, that it's not supported anywhere right now.

However, if you're going to work on it, I suggest you work along the lines of .add()ing individual files instead of copying everything to a temporary directory and adding that directory.

If fileobj is not None, then looks like a .addfile() can be used to prevent writing the data to disk more than once.

Please do post progress and questions in this issue.

@jhazentia jhazentia linked a pull request Jul 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants