Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoudiniEngineScheduler infinit while (true) #298

Open
manugulus opened this issue Apr 25, 2024 · 0 comments
Open

HoudiniEngineScheduler infinit while (true) #298

manugulus opened this issue Apr 25, 2024 · 0 comments

Comments

@manugulus
Copy link

In HoudiniEngineScheduler.cpp, in FHoudiniEngineScheduler::TaskInstantiateAsset and FHoudiniEngineScheduler::TaskCookAsset, in the while(true) we start by getting the status of the cook with:

int Status = HAPI_STATE_STARTING_COOK;
HOUDINI_CHECK_ERROR_GET(&Result, FHoudiniApi::GetStatus(FHoudiniEngine::Get().GetSession(), HAPI_STATUS_COOK_STATE, &Status));

if we loose the session being in those while true, the Result is set to HAPI_RESULT_FAILURE, but the Status is not updated and remains to HAPI_STATE_STARTING_COOK. However, the only break conditions of the while(true) are checking the Status so we end up looping indefinitely. I suggest a final check is added to the Status to ensure it's not HAPI_RESULT_FAILURE or to always update the Status in FHoudiniApi::GetStatus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant