Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SQL encoder #232

Open
si3nloong opened this issue Feb 23, 2023 · 0 comments · May be fixed by #175
Open

Refactor SQL encoder #232

si3nloong opened this issue Feb 23, 2023 · 0 comments · May be fixed by #175
Assignees
@si3nloong
Labels
bug Something isn't working enhancement New feature or request
Milestone
Version 2

Comments

@si3nloong
Copy link
Owner

si3nloong commented Feb 23, 2023 •
edited

Currently, the native driver.Valuer doesn't support statement like CURRENT_TIMESTAMP or UUID() on INSERT, UPDATE and DELETE.

The priority of encoding :

  1. reflect.TypeOf (actual data type)
  2. db.SqlValuer
  3. driver.Valuer
  4. reflect.Kind

But reflect.TypeOf will affected pointer data type.
@si3nloong si3nloong self-assigned this Feb 23, 2023
@si3nloong si3nloong added bug Something isn't working enhancement New feature or request labels Feb 23, 2023
@si3nloong si3nloong added this to the Version 2 milestone Feb 23, 2023
@si3nloong si3nloong linked a pull request Feb 24, 2023 that will close this issue
🔖 release: a brand new release v2, wow!!! 🥳 #175
Draft
17 tasks
@si3nloong si3nloong mentioned this issue Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@si3nloong si3nloong

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
Version 2
Development

Successfully merging a pull request may close this issue.

🔖 release: a brand new release v2, wow!!! 🥳 si3nloong/sqlike
1 participant
@si3nloong