Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Rocket tera template example #92

Open
Luni-4 opened this issue Sep 28, 2023 · 4 comments
Open

Add a Rocket tera template example #92

Luni-4 opened this issue Sep 28, 2023 · 4 comments

Comments

@Luni-4
Copy link

Luni-4 commented Sep 28, 2023

It would be helpful to add this tera example for Rocket to shuttle-examples. It only requires to enable the tera features in rocket_dyn_templates. Is this feature going to work on shuttle if enabled?

@oddgrd
Copy link
Contributor

oddgrd commented Oct 19, 2023

Hey! Yes, it should work, but I'm not sure we need a whole new example for it, since Rocket already has an example for it.

@Luni-4
Copy link
Author

Luni-4 commented Oct 19, 2023

Yes, you're right. Just wondering though whether an example in shuttle too could help in implementing a tera-template project more straightforward

@jonaro00
Copy link
Member

Considering this repo is a great pool of templates to start from, diversifying in this direction makes it more likely that we have a starter template for everyone, at the cost of maintenance burden.

@Luni-4
Copy link
Author

Luni-4 commented Oct 19, 2023

The current shuttle example could be changed as the Rocket example. So it is not necessary to add new examples and the maintenance burden will be reduced. The Rocket example uses both the templating mechanisms, so I presume a copy-paste approach should be sufficient, but I do not know the Shuttle effort, so I could be wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants