Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shorebird patch was only able to share <32% has the effect of damaging other functions in the application #2120

Open
rizkijuliansyaham opened this issue May 17, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@rizkijuliansyaham
Copy link

App ID: 07cd66fe-e347-4bb8-a732-71980e94daad

Description

After I changed several functions that did not touch native changes (packages were included in the previous iOS release), the patch process showed results

"[WARN] shorebird patch was only able to share 29.4% of dart code with the released app."

I thought it would continue to run normally, but after the patch was installed, my application, which had previously saved session data on SQLite, had an error and immediately logged out, when I tried to log in again, an error appeared indicating a SQLite error.

Steps To Reproduce

I just carried out the ios patch process as usual

Expected Behavior

Expectations will run normally because there is only a slight change in 1 function

Screenshots

WhatsApp Image 2024-05-17 at 09 58 12_9c4fe9fa

@rizkijuliansyaham rizkijuliansyaham added the bug Something isn't working label May 17, 2024
@felangel
Copy link
Contributor

Hi @rizkijuliansyaham 👋
Thanks for opening an issue! We're aware of this and are working hard to address it. See #1892 for more information 👍

@aloRanking
Copy link

add similar issue. after patching iOS. users app freezes on the splash screen. I had to quickly deactivated the patch.

Screenshot 2024-05-13 at 19 35 19 Screenshot 2024-05-13 at 19 37 37

Thank you for everything you have been doing.

@eseidel
Copy link
Contributor

eseidel commented May 17, 2024

I very much appreciate the feedback. We're very close on having this resolved. As felix notes, we're tracking it on #1892.

Right now in the wild we see about half of our customers having an excellent experience on iOS and about half of them having a poor (performance after patching) experience like you have here. We're quite confident that we should be able to get to the state of all customers having an excellent experience soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants