Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use shorebird's dart fork always #2105

Open
eseidel opened this issue May 15, 2024 · 0 comments
Open

feat: use shorebird's dart fork always #2105

eseidel opened this issue May 15, 2024 · 0 comments
Labels
tech debt Tasks that make the code cleaner, more maintainable, etc.

Comments

@eseidel
Copy link
Contributor

eseidel commented May 15, 2024

Right now we have a funny setup, where by flutter when invoked from shorebird will talk to downloads.shorebird.dev, which runs artifact_proxy, and will re-write some requests to pull shorebird artifacts rather than Google/flutter ones.

We replace many things, including gen_snapshot. However we do not replace the dart-sdk itself.

This causes kernel sdk_hash mismatches, so we've currently disabled kernel sdk_hash checks.

The correct solution to get around this is to vend our own Dart, rather than using Google's. This will require doing a few things:

  1. Making sure that when we build our Dart fork, it works correctly with all our #defines turned off.
  2. Set up build_engine and builders for all the various flavors of Dart we need to vend.
  3. Configure the artifact proxy to point to our uploaded Dart.
@felangel felangel added the tech debt Tasks that make the code cleaner, more maintainable, etc. label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Tasks that make the code cleaner, more maintainable, etc.
Projects
None yet
Development

No branches or pull requests

2 participants