Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop requiring users to understand -- #2086

Open
bryanoltman opened this issue May 13, 2024 · 5 comments
Open

fix: Stop requiring users to understand -- #2086

bryanoltman opened this issue May 13, 2024 · 5 comments

Comments

@bryanoltman
Copy link
Contributor

Description

The behavior of -- is confusing for users who haven't seen it before and also for users who don't understand which arguments shorebird parses and which are forwarded to Flutter. We should update our arg parsing to treat all flags/options equally so the user does not have to know/think about which are forwarded to Flutter

@eseidel
Copy link
Contributor

eseidel commented May 13, 2024

Interesting. I presumed we would just keep -- as an explicit pass-through and just add more args from Flutter to our explicit args? 🤷

@bryanoltman
Copy link
Contributor Author

I think it'd probably be easier if users just didn't need to think about it. I don't think there's a case where we would want different behavior for an arg on one side of the -- vs the other.

@eseidel eseidel changed the title Parse all arguments before and after -- fix: Stop requiring users to understand -- May 30, 2024
@eseidel
Copy link
Contributor

eseidel commented May 30, 2024

Bryan and I talked about this at some length. There are various methods we could take here, it doesn't matter a ton which. The end goal is all the same: users don't understand -- and we need to figure out how to stop having them need to.

e.g. one example would be to just have shorebird wrap flutter build explicitly, e.g. in GHA just have them type their normal flutter build command and we parse the command for Shorebird, or similarly shorebird build ... take exactly the same arguments as flutter build. We'd probably split the upload parts out from that or make them implicit in the build?

Another is as Bryan suggested that we keep our current shorebird release (since we do have things they need to pass) just make it so that either shorebird release accepts all the same arguments flutter build does (dynamically based on version? presumably with a custom ArgParser?).

@bryanoltman bryanoltman self-assigned this Jun 3, 2024
@eseidel
Copy link
Contributor

eseidel commented Jun 3, 2024

We brainstormed more about handling this in https://docs.google.com/document/d/1Y09EQhzksubPvo9Ilj9a2tPArQLM7DZYnp83QqHUE2Y/edit

@bryanoltman
Copy link
Contributor Author

Unassigning now that the above PR has landed. Will revisit if/when this comes up again.

@bryanoltman bryanoltman removed their assignment Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Support Burden
Development

No branches or pull requests

2 participants