-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Stop requiring users to understand --
#2086
Comments
Interesting. I presumed we would just keep |
I think it'd probably be easier if users just didn't need to think about it. I don't think there's a case where we would want different behavior for an arg on one side of the |
--
--
Bryan and I talked about this at some length. There are various methods we could take here, it doesn't matter a ton which. The end goal is all the same: users don't understand e.g. one example would be to just have shorebird wrap Another is as Bryan suggested that we keep our current |
We brainstormed more about handling this in https://docs.google.com/document/d/1Y09EQhzksubPvo9Ilj9a2tPArQLM7DZYnp83QqHUE2Y/edit |
Unassigning now that the above PR has landed. Will revisit if/when this comes up again. |
Description
The behavior of
--
is confusing for users who haven't seen it before and also for users who don't understand which arguments shorebird parses and which are forwarded to Flutter. We should update our arg parsing to treat all flags/options equally so the user does not have to know/think about which are forwarded to FlutterThe text was updated successfully, but these errors were encountered: