Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Android flavors starting with uppercase letters are incorrectly parsed #2031

Closed
bryanoltman opened this issue May 7, 2024 · 0 comments · Fixed by #2169
Closed

fix: Android flavors starting with uppercase letters are incorrectly parsed #2031

bryanoltman opened this issue May 7, 2024 · 0 comments · Fixed by #2169
Assignees
Labels
bug Something isn't working

Comments

@bryanoltman
Copy link
Contributor

bryanoltman commented May 7, 2024

With a gradle file like:

productFlavors {
        RJ {
            dimension "flavor-type"
            applicationId "br.com.brasizza.marcus.guia_rj"
            resValue "string", "app_name", "Guia do Rio de janeiro"
        }
        SP {
            dimension "flavor-type"
            applicationId "br.com.brasizza.marcus.guia_sp"
            resValue "string", "app_name", "Guia de São Paulo"
        }
    }

shorebird init recognized these flavors as

✓ 2 product flavors detected: (13.8s)
  - rJ
  - sP

See https://discord.com/channels/1030243211995791380/1237476178055397459

@bryanoltman bryanoltman added the bug Something isn't working label May 7, 2024
@erickzanardo erickzanardo self-assigned this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants