Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sExport should make usage of ProductListService, etc instead of own queries #2591

Open
mitelg opened this issue Sep 20, 2023 · 2 comments
Open

Comments

@mitelg
Copy link
Contributor

mitelg commented Sep 20, 2023

the product data in sExport is queried by a big SQL. this should be replaced with the ProductServices we have

Evaluate if this could be done in a bugfix release, otherwise we need to do it in 5.8

@teiling88
Copy link
Contributor

I think, this is not possible or you have an idea how to make the "sql custom filters" possible with the ProductService. :-)

@mitelg
Copy link
Contributor Author

mitelg commented Oct 25, 2023

you have a point here 😁

This was just a simple idea back then. Made without the knowledge of each and every possibility of the feature 😉

Maybe it could be done, if this feature is skipped and custom conditions could be added with a plugin 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants