Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added Pagination for Wishlist #893

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: added Pagination for Wishlist #893

wants to merge 6 commits into from

Conversation

khanSoliheen
Copy link

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 21, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview May 16, 2024 1:34pm

@khanSoliheen khanSoliheen reopened this Apr 21, 2024
@BrocksiNet BrocksiNet linked an issue Apr 22, 2024 that may be closed by this pull request
[FEATURE] Add pagination for wishlist page #894
Open
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 26, 2024 •
edited

CodSpeed Performance Report

Merging #893 will not alter performance

Comparing khanSoliheen:paginationForWishlistOrderHistoryPage (d7ff926) with main (f6b194e)

Summary

✅ 9 untouched benchmarks

@BrocksiNet BrocksiNet changed the title addedPaginationForWishlistChangesFewVariableNames feat: added Pagination for Wishlist Apr 30, 2024
mkucmus
mkucmus requested changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, looks really good 🙌🏼

👉🏼 Could you please adjust the tests because they are failing

@BrocksiNet
Copy link
Collaborator

hey, looks really good 🙌🏼

👉🏼 Could you please adjust the tests because they are failing

@kstala maybe you can help here? Would be nice to get this merged.

@BrocksiNet BrocksiNet requested a review from mkucmus May 16, 2024 13:22
@BrocksiNet
Copy link
Collaborator

BrocksiNet commented May 16, 2024 •
edited

@mkucmus, @kstala, and @khanSoliheen, I fixed the Test for the useWishlist composable.

Now, we have 100% coverage for the useWishlist composable. 🎉

Can be tested here: https://frontends-demo-h3h90r2m2-shopware-frontends.vercel.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkucmus mkucmus Awaiting requested review from mkucmus

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add pagination for wishlist page
3 participants
@khanSoliheen @BrocksiNet @mkucmus