Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Power Transform preprocessor to Shogun. #5052

Open
Hephaestus12 opened this issue Jun 2, 2020 · 6 comments
Open

Add a Power Transform preprocessor to Shogun. #5052

Hephaestus12 opened this issue Jun 2, 2020 · 6 comments

Comments

@Hephaestus12
Copy link
Contributor

Like the PowerTransformer in Scikit-learn or boxcox and yeojohnson in scipy.stats.

@karlnapf
Copy link
Member

karlnapf commented Jun 2, 2020

This shouldn't be too hard to add right?
You could have a go at this... (but let's first finish the poisson regression of course)

@Hephaestus12
Copy link
Contributor Author

Yes, I plan to start working on this after getting done with GLM. :)

@imsiddhant07
Copy link

@karlnapf may I take this up?

@gf712
Copy link
Member

gf712 commented Dec 7, 2020

@siddhantjain07 Go for it :)

@imsiddhant07
Copy link

Yes thanks, @gf712!
Could you please tell me, whether it should be

  1. A class with methods
  2. or a function within some preprocessing code.
    and should the file be .cpp or a .hpp
    Sorry if the doubts seem silly, but this my first time fixing some issue at something this big. Kindly bear with me :D

@gf712
Copy link
Member

gf712 commented Dec 7, 2020

This should be a class. No problem, have a look at other classes that inherit from Transform in https://github.com/shogun-toolbox/shogun/tree/develop/src/shogun/preprocessor, it should help get you started :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants