Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features for optional dependencies #2

Open
gf712 opened this issue May 29, 2020 · 0 comments
Open

Add features for optional dependencies #2

gf712 opened this issue May 29, 2020 · 0 comments

Comments

@gf712
Copy link
Member

gf712 commented May 29, 2020

Currently in build.rs shogun is linked against some libraries that the user might not have. So there should be features that enable/disable linking against these. However, this will depend on how shogun was compiled, so maybe features are not the best, and we should detect the libraries that shogun-static requires?
The features should also be passed on to CMake if we ever add shogun C++ as a submodule and the user compiles everything using cargo build.
See for example how ndarray does it:
https://github.com/rust-ndarray/ndarray/blob/f69248e977f42b7afb01f5c280baba1da09738c9/build.rs#L7-L9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant