Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] click delay on mobile devices with content in iframe #289

Open
Sebsta13 opened this issue Sep 14, 2018 · 1 comment
Open

[iOS] click delay on mobile devices with content in iframe #289

Sebsta13 opened this issue Sep 14, 2018 · 1 comment

Comments

@Sebsta13
Copy link

Sebsta13 commented Sep 14, 2018

Hi,

I found a weird issue while using tether in combination with content in iFrames.

If you have clickable content in iFrames and are using an iPhone, the click event don't trigger because the binding of the touchmove event:

if (typeof window !== 'undefined' && typeof window.addEventListener !== 'undefined') {
    ['resize', 'scroll', 'touchmove'].forEach(function (event) {
      window.addEventListener(event, tick);
    });
  }

You need to hold at least 250ms on the button to execute the event because of this:

if (typeof lastDuration !== 'undefined' && lastDuration > 16) {
      // We voluntarily throttle ourselves if we can't manage 60fps
      lastDuration = Math.min(lastDuration - 16, 250);

      // Just in case this is the last event, remember to position just once more
      pendingTimeout = setTimeout(tick, 250); // this is the problem
      return;
    }

Could someone please look into this?

Best regards

@RobbieTheWagner
Copy link
Member

@Strean1337 is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants