Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placement: top with dynamically changing content moves off screen on resize #248

Open
salminio opened this issue Mar 15, 2017 · 2 comments

Comments

@salminio
Copy link

My project is creating a popover with content that is a little interactive and can shrink or grow in size. When that happens sometimes the popover miscalculates the positions and either has a box really large starting offscreen with a negative xPos or totally offscreen (again with a negative xPos). In looking into the code, during move it somehow thinks the positioning is now fixed because the top location is not in the history check and thus it skips a check and moves into an else clause that forces 'fixed' position...

https://github.com/HubSpot/tether/blob/master/src/js/tether.js#L738

If I comment out that code, everything works (probably because I have no fixed content).

I was wondering if Tether could combine the scrollParent checking which can detect a fixed position and set a flag to know that fixed position is part of the equation and only do the fixed check if that flag is set?

@justinwinslow
Copy link

Did you ever find a resolution to this?

@salminio
Copy link
Author

salminio commented May 29, 2019

it is no longer an issue for us... Don't 100% remember the series of events that fixed it, but I believe we moved up in version of bootstrap and I think we switched to using boundary: 'window'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants