Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coloring of unfocussed windows makes text unreadable #300

Open
DarkTrick opened this issue Jul 13, 2021 · 4 comments
Open

Coloring of unfocussed windows makes text unreadable #300

DarkTrick opened this issue Jul 13, 2021 · 4 comments

Comments

@DarkTrick
Copy link
Contributor

DarkTrick commented Jul 13, 2021

XUbuntu 21.04 fresh install

Problem:

Coloring for unfocused selected items is "grey on blue" and therefore unreadable
image

Reproduce:

  • open Thunar
  • select a file
  • open 2nd Thunar
  • look at the first Thunar (without focussing it) and try to read the selected text
  • ACTUAL: Grey font on blue background (see example image above)
  • EXPECTED: Black font on grey background (see below)

Suggested solution

There are many possible solutions to this.
I suggest:
Unfocussed selected items should have

  • usual font color
  • grey background

edit: Example with current font-color:
image

Reason:
It solves two issues at once:

  1. The issue of unreadability described here
  2. The issue, that it's often not clear which element has focus (I guess this was tackled by the change in font color to grey)

Notes

This is a copy of the report on launchpad: https://bugs.launchpad.net/ubuntu/+source/shimmer-themes/+bug/1935019

@ochosi
Copy link
Member

ochosi commented Sep 5, 2021

I would swap out the grey for a very light grey on selected backgrounds in unfocused windows.

PRs welcome!

@ochosi
Copy link
Member

ochosi commented Sep 6, 2021

"pull requests welcome" (as in: I'm not sure when I'll get to this)

@DarkTrick
Copy link
Contributor Author

I figured out the place to change it must be somewhere around here:

Greybird/light/gtk-3.0/_common.scss

// catch all extend :)

%selected_items {
  background-color: $selected_bg_color;

  ...
}

However, for whatever reason the &:disabled selector does not seem to work here. So the following has no effect:

// catch all extend :)

%selected_items {
  background-color: $selected_bg_color;

  &:disabled {
    background-color: #FF0000; /*testcolor*/
  }

  ...
}

If someone knows the trick, please let me know....

DarkTrick added a commit to DarkTrick/Greybird that referenced this issue Sep 25, 2021
Before: "blue on grey" was unreadable.
Issue: shimmerproject#300

Deleted several specific styles in favor of one general style.
@DarkTrick
Copy link
Contributor Author

Here's my MR: #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants