Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testvecabi fails to build on some x86 arch with -march=native #478

Open
blapie opened this issue Nov 7, 2023 · 0 comments
Open

Testvecabi fails to build on some x86 arch with -march=native #478

blapie opened this issue Nov 7, 2023 · 0 comments

Comments

@blapie
Copy link
Collaborator

blapie commented Nov 7, 2023

It was pointed out in #476 that x86 build of testvecabi was failing due to a mismatch in CPU features.

https://github.com/rivosinc/sleef/actions/runs/6753516221/job/18360067282

This could be lifted by removing the -march=native option used to compile testvecabi, that was clashing with the -mavx512f option used to compile routines.

Should we re-enable this feature and fix issue with ABI uncovered by -march=native?
@blapie blapie mentioned this issue Nov 7, 2023
Merged
blapie pushed a commit that referenced this issue Nov 10, 2023
@luhenry
Add CI on Github Actions for x86_64, aarch64, arm, ppc64 and s390x (#476
69cfa71 
)

* Add CI on Github Actions for x86_64, aarch64, armhf, ppc64 and s390x
* Disable -march=native for testervecabi - fails when compiling on a host CPU with AVX512f (#478)
* Enable qemu features for s390x, ppc64, and arm
* Add some architecture-specific cmake flags
* Use job dependencies to avoid duplicating building native
* Fix permissions in downloaded artifacts
* Disable arm inline headers - don't work (#480)
* Document why DISABLE_VXE2 on s390x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blapie