Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to syn 2.0, darling 0.20 #386

Merged
merged 2 commits into from Dec 28, 2023
Merged

Update to syn 2.0, darling 0.20 #386

merged 2 commits into from Dec 28, 2023

Conversation

wcampbell0x2a
Copy link
Collaborator

@wcampbell0x2a wcampbell0x2a commented Dec 23, 2023 •
edited

  • Change type for enums into id_type, as this is no longer accepted through the syn parser library
  • Update rstest to 0.18.0 to rid of another syn1 depend.

Closes #351

syn is still built for dev-dependencies, of which alloc_counter hasn't been update in a while:

  39   │ [dev-dependencies]
  40   │ ├── alloc_counter v0.0.4
  41   │ │   ├── alloc_counter_macro v0.0.2 (proc-macro)
  42   │ │   │   ├── proc-macro2 v1.0.69 (*)
  43   │ │   │   ├── quote v1.0.33 (*)
  44   │ │   │   └── syn v1.0.109

@wcampbell0x2a
Update to syn 2.0, darling 0.20
e4e84a0 
- Change `type` for enums into `id_type`, as this is no longer
accepted through the syn parser library
@github-actions GitHub Actions
Copy link

Benchmark for ea20cc5

Click to view benchmark
Test Base PR %
deku_read_bits 1285.5±15.26ns 1346.5±10.29ns +4.75%
deku_read_byte 21.7±0.27ns 21.5±0.54ns -0.92%
deku_read_enum 9.3±0.17ns 9.5±0.68ns +2.15%
deku_read_vec 60.0±1.55ns 58.6±0.58ns -2.33%
deku_write_bits 217.1±3.12ns 208.7±3.18ns -3.87%
deku_write_byte 22.2±3.95ns 21.2±0.80ns -4.50%
deku_write_enum 19.9±0.34ns 19.9±0.33ns 0.00%
deku_write_vec 306.9±3.89ns 304.8±5.32ns -0.68%

@github-actions GitHub Actions
Copy link

Benchmark for 4a26df1

Click to view benchmark
Test Base PR %
deku_read_bits 1337.9±18.10ns 1228.3±9.54ns -8.19%
deku_read_byte 21.6±0.81ns 21.4±0.33ns -0.93%
deku_read_enum 9.5±0.18ns 9.5±0.17ns 0.00%
deku_read_vec 57.8±1.02ns 58.8±4.82ns +1.73%
deku_write_bits 205.8±1.92ns 209.5±3.60ns +1.80%
deku_write_byte 21.1±0.43ns 21.2±0.58ns +0.47%
deku_write_enum 19.8±0.20ns 19.9±0.35ns +0.51%
deku_write_vec 310.1±3.53ns 332.7±3.70ns +7.29%

@github-actions GitHub Actions
Copy link

Benchmark for 7644624

Click to view benchmark
Test Base PR %
deku_read_bits 1272.8±8.49ns 1236.1±38.46ns -2.88%
deku_read_byte 21.4±0.54ns 21.0±0.59ns -1.87%
deku_read_enum 9.4±0.17ns 9.5±0.14ns +1.06%
deku_read_vec 59.1±0.71ns 57.6±0.59ns -2.54%
deku_write_bits 211.6±5.93ns 212.7±1.80ns +0.52%
deku_write_byte 21.1±0.37ns 21.1±0.34ns 0.00%
deku_write_enum 20.2±0.40ns 20.2±0.51ns 0.00%
deku_write_vec 300.1±4.04ns 293.6±2.99ns -2.17%

@wcampbell0x2a wcampbell0x2a linked an issue Dec 27, 2023 that may be closed by this pull request
Update darling; Use syn 2 #351
Closed
@wcampbell0x2a wcampbell0x2a merged commit 61d4d2f into impl-writer Dec 28, 2023
18 of 19 checks passed
@wcampbell0x2a wcampbell0x2a deleted the update-to-syn2 branch December 28, 2023 02:26
wcampbell0x2a added a commit that referenced this pull request Dec 28, 2023
@wcampbell0x2a
Update to syn 2.0, darling 0.20 (#386)
f31befa 
* Update to syn 2.0, darling 0.20

- Change `type` for enums into `id_type`, as this is no longer
accepted through the syn parser library

* Update to rstest 0.18
wcampbell0x2a added a commit that referenced this pull request Dec 28, 2023
@wcampbell0x2a
Update to syn 2.0, darling 0.20 (#386)
8f540c3 
* Update to syn 2.0, darling 0.20

- Change `type` for enums into `id_type`, as this is no longer
accepted through the syn parser library

* Update to rstest 0.18
wcampbell0x2a added a commit that referenced this pull request Dec 28, 2023
@wcampbell0x2a
Update to syn 2.0, darling 0.20 (#386)
479f24e 
* Update to syn 2.0, darling 0.20

- Change `type` for enums into `id_type`, as this is no longer
accepted through the syn parser library

* Update to rstest 0.18
wcampbell0x2a added a commit that referenced this pull request Dec 28, 2023
@wcampbell0x2a
Update to syn 2.0, darling 0.20 (#386)
190d64a 
* Update to syn 2.0, darling 0.20

- Change `type` for enums into `id_type`, as this is no longer
accepted through the syn parser library

* Update to rstest 0.18
wcampbell0x2a added a commit that referenced this pull request Dec 28, 2023
@wcampbell0x2a
Update to syn 2.0, darling 0.20 (#386)
44554c5 
* Update to syn 2.0, darling 0.20

- Change `type` for enums into `id_type`, as this is no longer
accepted through the syn parser library

* Update to rstest 0.18
wcampbell0x2a added a commit that referenced this pull request Dec 28, 2023
@wcampbell0x2a
Update to syn 2.0, darling 0.20 (#386)
16319f8 
* Update to syn 2.0, darling 0.20

- Change `type` for enums into `id_type`, as this is no longer
accepted through the syn parser library

* Update to rstest 0.18
wcampbell0x2a added a commit that referenced this pull request Dec 28, 2023
@wcampbell0x2a
Update to syn 2.0, darling 0.20 (#386)
6134243 
* Update to syn 2.0, darling 0.20

- Change `type` for enums into `id_type`, as this is no longer
accepted through the syn parser library

* Update to rstest 0.18
wcampbell0x2a added a commit that referenced this pull request Apr 5, 2024
@wcampbell0x2a
Update to syn 2.0, darling 0.20 (#386)
a9db889 
* Update to syn 2.0, darling 0.20

- Change `type` for enums into `id_type`, as this is no longer
accepted through the syn parser library

* Update to rstest 0.18
wcampbell0x2a added a commit that referenced this pull request Apr 29, 2024
@wcampbell0x2a @rbran
Impl writer (#355)
79ca046 
* Add skipping to logging

* Impl Write support

* remove the writer reference requirement (#384)

* Update to syn 2.0, darling 0.20 (#386)

* Update to syn 2.0, darling 0.20

- Change `type` for enums into `id_type`, as this is no longer
accepted through the syn parser library

* Update to rstest 0.18

* Update CHANGELOG

* Make DekuContainerWrite a default impl

- Reduce codegen by making this a default impl

* Impl DekuWriter for Box<T>

* Address MR feedback

* Add slice const_generic testing

---------

Co-authored-by: Rubens Brandão <git@rubens.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharksforarms sharksforarms sharksforarms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update darling; Use syn 2
2 participants
@wcampbell0x2a @sharksforarms