Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"yarn install" installs tape with breaking changes #79

Open
PaulTomchik opened this issue May 26, 2020 · 0 comments · May be fixed by #80
Open

"yarn install" installs tape with breaking changes #79

PaulTomchik opened this issue May 26, 2020 · 0 comments · May be fixed by #80

Comments

@PaulTomchik
Copy link

PaulTomchik commented May 26, 2020

The project README's Development Install instructions specify using yarn.
However, the project includes a package-lock.json and no yarn.lock.
Additionally, the project's package.json uses the wildcard for the tape version.

As a result, yarn install installs version 5.0.1 of tape, while npm install installs version 4.10.1.

Tape v5.0.0 included a breaking change for the deepEqual function (tape-testing/tape#508).

This breaking change causes the "tiles -- build tile paths " tests to fail in test_code.ts.

yarn import generates the yarn.lock file that fixes the problem.

@PaulTomchik PaulTomchik linked a pull request May 26, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant