Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese Caption Downloading Solution #268

Open
stephenleeys opened this issue May 2, 2024 · 0 comments
Open

Chinese Caption Downloading Solution #268

stephenleeys opened this issue May 2, 2024 · 0 comments

Comments

@stephenleeys
Copy link

I am Chinese user. When I was trying to use the downloader to download video with chinese cation, I chose the language option "Chinese". However, no caption will be downloaded. It is because the language code used in youtube caption is not correct.

I've looked through the code and find the language code setting of downloader and language code of the youtube player, Here is the solution:

Download the source code of this repo. Open the solution file by Visual Studio. Make sure your VS is in version 17.8+.

Inside file "DownloadSettingsControl.xaml.cs", in line 26 (it might not be the same line if different version, I was using downloader v1.9.24), find the dictionary:
private readonly Dictionary<string, string> Languages ....

Add the two element somewhere inside the dictionary
{ "zh-Hans", "Chinese Simplified" }, { "zh-Hant", "Chinese Traditional" },

It should looks similar:
private readonly Dictionary<string, string> Languages = new() { { ..., "zh-Hans", "Chinese Simplified" }, { "zh-Hant", "Chinese Traditional" }, ... } }

Please be sure you don't copy the line directly. "..." is rest of the language option.

Build the solution and start the program. Make sure you have the "ffmpeg.exe" in your build directory. Just copy it from the official release is fine.

If @shaked6540 have time, I sincerely hope that the correct language code can be added in the next update. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant