Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the --summarize rust test option #3207

Open
stevenengler opened this issue Oct 12, 2023 · 0 comments
Open

Consider removing the --summarize rust test option #3207

stevenengler opened this issue Oct 12, 2023 · 0 comments
Labels
Type: Maintenance Refactoring, cleanup, documenation, or process improvements

Comments

@stevenengler
Copy link
Contributor

stevenengler commented Oct 12, 2023

Many of Shadow's rust tests have a --summarize option which will continue to run tests even after a test fails. The goal was to provide an overview of what tests were passing/failing, but I don't think we've ever really used this. It also makes writing tests a little more painful, since any tests using this feature need to return a result rather than panic. Using panicking failures in tests is nicer than results, since then you can use assert! and panic!. Returning a result also means that we need to write cleanup code for tests that fail, since other tests may still run after the failed test.

It would simplify the tests if we removed this option and use panicking tests instead.

@stevenengler stevenengler added the Type: Maintenance Refactoring, cleanup, documenation, or process improvements label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Refactoring, cleanup, documenation, or process improvements
Projects
None yet
Development

No branches or pull requests

1 participant