Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD Cleanup: CFG normalization replaces break statements with a boolean break flag bflag, but this currently means the opposite of what it should #4187

Open
saipraveenb25 opened this issue May 17, 2024 · 0 comments
Assignees
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang GoodFirstBug Great bug for people getting going in slang codebase kind:cleanup tech debt and rough edges

Comments

@saipraveenb25
Copy link
Collaborator

This is a very minor cleanup but is nevertheless important, because reading through the code is very confusing when break_flag = true means 'keep going' and break_flag = false means 'break'.

@saipraveenb25 saipraveenb25 added kind:cleanup tech debt and rough edges GoodFirstBug Great bug for people getting going in slang codebase goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang labels May 17, 2024
@saipraveenb25 saipraveenb25 self-assigned this May 17, 2024
@saipraveenb25 saipraveenb25 added this to the Q3 2024 (Summer) milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang GoodFirstBug Great bug for people getting going in slang codebase kind:cleanup tech debt and rough edges
Projects
None yet
Development

No branches or pull requests

1 participant