Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments Bug #64

Open
xor0x opened this issue Mar 31, 2019 · 7 comments
Open

Comments Bug #64

xor0x opened this issue Mar 31, 2019 · 7 comments

Comments

@xor0x
Copy link

xor0x commented Mar 31, 2019

You have a bug in comments please open this video
https://youtu.be/dJDMX33Y22g

@shacker
Copy link
Owner

shacker commented Mar 31, 2019

...but you are hitting Refresh each time, right? I should probably redirect back to the original page after posting a comment so that's not possible, but I would consider that an enhancement rather than a bug. Easy though, will do.

@xor0x
Copy link
Author

xor0x commented Mar 31, 2019

I do this with the script on base.hml

<script> if ( window.history.replaceState ) { window.history.replaceState( null, null, window.location.href ); } </script>

@shacker
Copy link
Owner

shacker commented Mar 31, 2019

Suggestion: Rather than paper over with javascript what you perceive to be a bug in the app, instead submit a pull request that actually fixes it in the app itself. The flow for this is well-documented in the Django docs.

@datatalking
Copy link

@shacker I can take a look at this.

So from what I understand @xor0x says is a bug but we are calling an enhancement that when a comment is added to a task. The drop down comes up, but instead the enhancement is to disable the pop up window that displays
Screen Shot 2021-08-22 at 5 25 02 PM

Then build in an enhancement where the comment on the task is not duplicated rather is just added once?

@datatalking
Copy link

@xor0x I've got a bit more time and found you replied to my comments. I was trying to summarize your challenge that it was creating duplicates when you hit refresh... you responded with 'confused' emoji so I'm asking if I was correct in understanding your issue.

@xor0x
Copy link
Author

xor0x commented Apr 6, 2022

@datatalking You're right.

@SkSaadAli
Copy link

The video is no longer available can you explain what the issue was?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants