Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premature hiding of rows #60

Open
rexjrs opened this issue Aug 9, 2017 · 7 comments
Open

Premature hiding of rows #60

rexjrs opened this issue Aug 9, 2017 · 7 comments

Comments

@rexjrs
Copy link

rexjrs commented Aug 9, 2017

When scrolling upwards, it uses its performance technique which hides the row but it does it prematurely.

As soon as the bottom of the row touches the bottom of the screen when scrolling up, that row vanishes. I think what it should do instead if hide the row after it scrolls below the bottom edge of the screen, not as soon as it touches it.

@davidroman0O
Copy link

davidroman0O commented Oct 19, 2017

Same issue @sghiassy

@martinosmartinos
Copy link
Contributor

Same here and looks bad once hight of a row holding a cell is ca half of a screen. Scrolling upwards leaves almost whole screen blank. Did try premptiveLoading option but with no luck :(

@martinosmartinos
Copy link
Contributor

@sghiassy is there any fix for it or at least direction what causing this issue?

@sghiassy
Copy link
Owner

Not sure. Truthfully I haven't looked at this project in awhile.

Have you tried using prop: premptiveLoading? If that doesn't work, perhaps scrollRenderAheadDistance?

@martinosmartinos
Copy link
Contributor

martinosmartinos commented Jan 21, 2018

I did try props you mentioned. Basically if one scrolls up then item becomes invisible once its' bottom hits bottom of a screen. Looks like this item becomes part of premptiveLoading. Here is a sequence of a screenshots of what is happening while scrolling up.

screenshot_2018-01-21-12-38-38_com mongabay news
screenshot_2018-01-21-12-38-42_com mongabay news
screenshot_2018-01-21-12-38-47_com mongabay news

@sghiassy
Copy link
Owner

Seems like there's a bug in the library's logic of determining when to hide/show cells. Either we're calculating the cell's dimensions incorrectly in calculateDimensionsForCell or we're incorrectly gauging when to hide/show it in updateCellsPremptively. Not sure when I'll have time to tackle it tho :/

Happy to list you as a contributor on the repo if you can nail this bug ;)

@martinosmartinos
Copy link
Contributor

@sghiassy it is definetly something strange in calculateDimensionsForCell as first element in childFrames is always staying on 0 - height, 0- width and gets y-coordinates of a loaded list.
screen shot 2018-01-31 at 15 02 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants