Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollRenderAheadDistance, stickyHeaderIndices #28

Open
pesterhazy opened this issue Aug 5, 2016 · 2 comments
Open

scrollRenderAheadDistance, stickyHeaderIndices #28

pesterhazy opened this issue Aug 5, 2016 · 2 comments

Comments

@pesterhazy
Copy link

With RN 0.30.0, warnings appear about the two props mentioned in the title:

 <Warning>: Warning: Failed prop type: Required prop `stickyHeaderIndices` was not specified in `SGListView`.

It's easy to get rid of the warnings by adding the default values (1000 and [], respectively).

This is the relevant bit in the RN code: https://github.com/facebook/react-native/blob/975d196c67dfbe657e9027eb96c9d6ab218c9f17/Libraries/CustomComponents/ListView/ListView.js#L247-L256

Ideally these should not be required props for SGListView as they have default values in the ListView code.

Thanks for the life-saving module!

@chandlervdw
Copy link

In addition, how are you supposed to use premptiveLoading if it can conflict with scrollRenderAheadDistance?

@sghiassy
Copy link
Owner

sghiassy commented Oct 4, 2016

@pesterhazy - Any chance you have time to submit a PR that uses those constants in SGListView? I'm super booked unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants