-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conda Install #24
Comments
Hello, Sorry for the delay on this issue. My job is keeping me busy and it is hard to find time for this project. I will take a look and try to do it this weekend. Thanks for the comment. |
Fantastic, thanks so much. |
Hi @JChristopherEllis and @sestaton, @sestaton, I made a recipe for installing |
This is great @fdchevalier! Thanks for the recipe. I will test it myself and give you some feedback. It terms of maintenance, it might be better put in this repo so I can add a git hook or build script to make a new release, update docker, conda, etc. in one step. That way they all stay in sync on a new release. |
Hello Frederic,
This is terrific news and I look forward to trying this install out.
Thanks Again,
Chris
…On Tue, May 24, 2022 at 17:10 Frédéric Chevalier ***@***.***> wrote:
Hi @JChristopherEllis <https://github.com/JChristopherEllis> and @sestaton
<https://github.com/sestaton>,
@sestaton <https://github.com/sestaton>, I made a recipe for installing
hmmer2go through conda (see here
<https://github.com/fdchevalier/conda-recipes/tree/main/hmmer2go>). I
tested it on CentOS 7 and Ubuntu 20.04 (WSL) successfully. The recipe is
ready to be submitted to bioconda. However, I wanted to check with you
first to make sure this is OK and to know if you want to maintain this or
want me to do so (this is pretty low maintenance and fine by me).
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIZH4AYPP2XDEMRBVHYVKPDVLVAU5ANCNFSM4ZZRSBBQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi everyone, Thank you for the feedback! @sestaton, I totally agree regarding maintenance. This will be more sensible. I also made some modifications to the recipe today. I added a test section. Running the Anyway, let me know if you have any questions or need any help with this. |
Thanks again, @fdchevalier. We do not need to run tests in the containers. Every change made to the code triggers a test matrix to run on a fresh virtual machine. Those should pass because they are tested before being incorporated but sometimes issues arise. Any release with a version number would have passed all the tests. The tests themselves cannot be run as a plain Perl script. They need to run with the make file or manually with a program called
That will run all the tests but you can specify individual tests to run:
Network tests are skipped by default. You can run the full test suite by setting In the demo section of the wiki you can see an example to run the full process, which does assume Pfam is not on the machine. |
@fdchevalier Can you give some guidance on the test setup for the conda recipe? I would like to know we are testing things in an equivalent environment or method. I will add the recipes here and create a pull request to add them to the bioconda repo once it is tested. |
Hi @sestaton, First, I don't know how familiar you are with running tests when creating a package with a conda recipe. To make sure we are on the same page, here is my understanding of the process. When the package is built, conda performs test if their is a Regarding the tests, they are run only during package building not installation. So if you submit your recipe to the bioconda repo, the repo will build the package and test it. As I mentioned there are two ways to do them:
As of note, I actually tried to remove the run script and add If you want me to test your recipe, I would be happy to do so. If you need more info or if I missed something, please let me know. |
Hi,
Several months ago we discussed a new conda install. Is that still in the works?
The text was updated successfully, but these errors were encountered: