Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume Settings Should be An Array #513

Open
danpastori opened this issue May 4, 2022 Discussed in #512 · 0 comments 路 May be fixed by #514
Open

Volume Settings Should be An Array #513

danpastori opened this issue May 4, 2022 Discussed in #512 · 0 comments 路 May be fixed by #514
Assignees
Labels

Comments

@danpastori
Copy link
Contributor

Discussed in #512

Originally posted by danpastori May 4, 2022

馃憠 Describe the problem

There are multiple volume settings that you can pass to AmplitudeJS such as starting volume, increment and decrement. These should be in an object instead of individual values.

馃懃 Problem evidence & reach

Users who want to define volume settings will find the new solution much easier to group and organize.

馃グ Describe the "impact" on users?

Volume settings will be easier to read and organize.

馃弳 How to solve this problem

Instead of passing in:

{
volume_increment: 5,
volume_decrement: 5,
starting_volume: 50
}

The user would pass in:

{
	volume: {
	    increment: 5,
	    decrement: 5,
	    starting: 50
	}
}

馃挴 How do we validate the problem is solved?

Users can pass an object for volume settings that makes it much easier to manage.

@danpastori danpastori added the Enhancement 鈿★笍 New feature label May 4, 2022
@danpastori danpastori self-assigned this May 4, 2022
@danpastori danpastori linked a pull request Jun 3, 2022 that will close this issue
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for QA
Development

Successfully merging a pull request may close this issue.

1 participant