Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

playlists key should be collections #511

Open
danpastori opened this issue May 4, 2022 Discussed in #510 · 0 comments 路 May be fixed by #514
Open

playlists key should be collections #511

danpastori opened this issue May 4, 2022 Discussed in #510 · 0 comments 路 May be fixed by #514
Assignees
Labels

Comments

@danpastori
Copy link
Contributor

danpastori commented May 4, 2022

Discussed in #510

Originally posted by danpastori May 4, 2022

馃憠 Describe the problem

When working with podcasts and other audio groupings, the key playlists doesn't make much sense. We should refactor this to collections to accommodate more audio solutions.

馃懃 Problem evidence & reach

Anyone using AmplitudeJS for anything but songs.

馃グ Describe the "impact" on users?

Their code will match what they are using AmplitudeJS for.

馃弳 How to solve this problem

This is a breaking change so we need to thoroughly document this. We rename and refactor the playlists key to be collections and allow users to define audio and other metadata for the grouping that we can use for display.

馃挴 How do we validate the problem is solved?

The user can submit a collections key to their initialize function that groups audio files.

@danpastori danpastori added the Enhancement 鈿★笍 New feature label May 4, 2022
@danpastori danpastori self-assigned this May 4, 2022
@danpastori danpastori changed the title playlists key should be groupings playlists key should be collections May 19, 2022
@danpastori danpastori linked a pull request Jun 3, 2022 that will close this issue
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for QA
Development

Successfully merging a pull request may close this issue.

1 participant