Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename songs array to audio array in Config #504

Open
danpastori opened this issue May 4, 2022 Discussed in #503 · 0 comments 路 May be fixed by #514
Open

Rename songs array to audio array in Config #504

danpastori opened this issue May 4, 2022 Discussed in #503 · 0 comments 路 May be fixed by #514
Assignees
Labels

Comments

@danpastori
Copy link
Contributor

Discussed in #503

Originally posted by danpastori May 4, 2022

馃憠 Describe the problem

Right now you add audio to the AmplitudeJS configuration through a songs array. This doesn't make sense if you are working with audio files that aren't songs such as podcasts.

馃懃 Problem evidence & reach

Any user that works with podcasts, interviews, etc.

馃グ Describe the "impact" on users?

It's more developer friendly to name the songs array as audio if the user is working with audio files that aren't songs (i.e podcasts).

馃弳 How to solve this problem

Rename the songs array to audio and update all references within the code. This will be a breaking change from 5.3 -> 6.0 but will document it.

馃挴 How do we validate the problem is solved?

Users can semantically set audio instead of songs within AmplitudeJS making it more inline with their use case.

@danpastori danpastori added the Enhancement 鈿★笍 New feature label May 4, 2022
@danpastori danpastori self-assigned this May 4, 2022
@danpastori danpastori linked a pull request May 6, 2022 that will close this issue
75 tasks
@danpastori danpastori linked a pull request Jun 3, 2022 that will close this issue
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready for QA
Development

Successfully merging a pull request may close this issue.

1 participant