Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The two abnormal situations of obtaining dynamic configuration that does not exist and exceptions should better be distinguished. #1243

Open
tunefun opened this issue Jul 6, 2023 · 0 comments
Assignees
Labels
area/framework Issues or PRs releated to sermant core service kind/feature Issue for new feature

Comments

@tunefun
Copy link

tunefun commented Jul 6, 2023

What would you like to be added?

Currently: the obtained dynamic configuration does not exist or an exception returns null, which cannot be distinguished. com.huaweicloud.sermant.core.service.dynamicconfig.api.KeyService#getConfig
Required: An exception is thrown when the dynamic configuration fails to be obtained.

Why is this needed?

The plugin needs to perform different operations when it is exceptional or when it is null.

@tunefun tunefun added the kind/feature Issue for new feature label Jul 6, 2023
@luanwenfei-venus luanwenfei-venus added the area/framework Issues or PRs releated to sermant core service label Jul 11, 2023
@luanwenfei-venus luanwenfei-venus added this to the v1.2.0 milestone Jul 11, 2023
@lilai23 lilai23 self-assigned this Jul 21, 2023
@hanbingleixue hanbingleixue assigned TangLeDaily and unassigned lilai23 Aug 2, 2023
@github-actions github-actions bot added the Stale label Aug 31, 2023
@github-actions github-actions bot closed this as completed Sep 2, 2023
@hanbingleixue hanbingleixue removed this from the v1.2.0 milestone Sep 12, 2023
@hanbingleixue hanbingleixue reopened this Sep 18, 2023
@github-actions github-actions bot added the Stale label Oct 27, 2023
@kkf1 kkf1 changed the title 获取动态配置不存在和异常两种情况可以被区分 The two abnormal situations of obtaining dynamic configuration that does not exist and exceptions should better be distinguished. Apr 13, 2024
@sermant-io sermant-io deleted a comment from github-actions bot May 10, 2024
@sermant-io sermant-io deleted a comment from github-actions bot May 10, 2024
@sermant-io sermant-io deleted a comment from github-actions bot May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/framework Issues or PRs releated to sermant core service kind/feature Issue for new feature
Projects
None yet
Development

No branches or pull requests

5 participants