Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent extension from splitting inline-code and link marks #13

Open
aquibbaig opened this issue Mar 15, 2024 · 1 comment
Open

prevent extension from splitting inline-code and link marks #13

aquibbaig opened this issue Mar 15, 2024 · 1 comment

Comments

@aquibbaig
Copy link

Currently, the extension will split around the inline code block or a link for the final markup as follows:
code block and the markup looks like this:

<span class="my-comment" data-comment-id="ac5353dc3-357f-4ea9-b9b8-9500bf7aa76fa">prevent extension from splitting </span>
<code>code</code>
<span class="my-comment" data-comment-id="ac5353dc3-357f-4ea9-b9b8-9500bf7aa76fa"> blocks and links</span>

I'd prefer it as follows:

<span class="my-comment" data-comment-id="ac5353dc3-357f-4ea9-b9b8-9500bf7aa76fa">
prevent extension from splitting <code>code</code> blocks and links
</span>
@sereneinserenade
Copy link
Owner

Code.extend({
  excludes: "",
})

should allow comments on code mark.

don't think it'll render code inside comment span, for prosemirror has a special way of rendering multiple marks on the same text & it doesn't nest one inside another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants