Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better hadling for selection in interactive menu (Skip,Abort, etc.) so they won't be marked as "completed" #120

Open
knuurr opened this issue Jan 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@knuurr
Copy link

knuurr commented Jan 11, 2024

Currently, imports where manual action was needed, and during which Beets was told to either Skip that particual album, or Abort import, are detected by UI as success:

obraz

obraz

Now I get it that it's probably based on exit code, and probably Beets doesn't dare to report Aborted import as non-zero.

IDEA: would it be possible to check at betanin level, that:

  • check if Beets printed prompt about action to be taken,
  • and if so, track the response to that
  • based on user input, communicate action taken in GUI - for clarity

In GUI this could be reported for example in brackets, what action was taken regarding that particular import. With that one could easily come back to that later, in case they wanted to take action again against that albu that was problematic, because currently such import will be displayed as "Completed".

Here's small demo on how could it look (excuse me but I didn't bother to change colors nor icon. Let's assume Abort could be in red, Skip in yellow/red, Use-as maybe tifferent hue of green etc.)

obraz

My assumption here is that it's possible to capture whenever this interactive menu is displayed, and that user always provides predictable input within possible options. Maybe more thought should be provided into what appens if user misstypes etc.

@sentriz
Copy link
Owner

sentriz commented Jan 11, 2024

i agree it would be nice to have extra info, but if input is required you should get a notification like that. recently the beets UI was updated and betanin didnt updated. see #114 for more info

image

@sentriz sentriz added the enhancement New feature or request label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants