Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Failing tests on MacOS related to lock-related EOExecutor tests #578

Open
mlubej opened this issue Feb 22, 2023 · 1 comment
Open
Labels
bug Something isn't working

Comments

@mlubej
Copy link
Contributor

mlubej commented Feb 22, 2023

Describe the bug

Tests mentioned above fail on MacOS. Not sure if they already failed before or not. Probably not many people run this anyway.

To Reproduce

  1. Git gud job
  2. Git gud salary
  3. Git gud macbook
  4. Run eo-learn tests

Expected behavior

Passing tests

Environment

  • Python 3.10
  • pyenv venv environment
  • sh-py and eo-learn installed in edit mode (develop versions)

Stack trace or screenshots

Running pytest core/eolearn/tests/test_eoexecutor.py -k lock results in:

image

Desktop (please complete the following information):

  • OS: MacOS Ventura 13.2.1

Additional context

This might be related to the known issue of MacOS and Windows, where the multiprocessing spawn method has to be set to fork via:

import multiprocessing
multiprocessing.set_start_method('fork')

This method is the default on Linux, but not on Mac and probably not on Windows as well. This is what I usually have to do to make parallelization work in notebooks and such.

The mentioned tests also work if I set the method in the failing tests file to fork, but I'm not sure if that's the proper way to go about it.

@mlubej mlubej added the bug Something isn't working label Feb 22, 2023
@batic
Copy link
Contributor

batic commented Feb 23, 2023

For some context, see also bp-33725.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants