Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interims field cannot be imported appropriately via two dimension csv #2461

Open
erikking opened this issue Jan 4, 2024 · 0 comments
Open

Comments

@erikking
Copy link

erikking commented Jan 4, 2024

Description

Interims field cannot be imported appropriately via two dimension csv in our use case, not sure it is expected behaviour for common lab use.

  1. AR analysis with multiple interims fields, only first interim can be imported via csv import parser
  2. interims fields cannot be imported if analysis is ReferenceAnalysis or DuplicateAnalysis

Reproduction guide

CSV example:

,analysis,interim1,interim2,end
AP-0001,1,2,3,
AP-0001-D01,4,5,6,
QC-0001-001,7,8,9,
end

Observed behaviour

Only AP-0001's interim1 can be imported. And following data cannot be loaded

  1. AP-0001's interim2
  2. AP-0001-D01's interim1,interim2
  3. QC-0001-001's interim1,interim2

Expected behaviour

All data can be imported via csv files.

Versions

  • senaite.core: 2.4.1 or 2.5.0

Cause

Only first interim can be imported

https://github.com/senaite/senaite.core/blob/v2.5.0/src/senaite/core/exportimport/instruments/generic/two_dimension.py#L235C1-L236C1

Looks like the break and continue break the 2nd, 3rd, etc. interims import.

ReferenceAnalysis or DuplicateAnalysis interim fields cannot be imported

https://github.com/senaite/senaite.core/blob/v2.5.0/src/senaite/core/exportimport/instruments/generic/two_dimension.py#L90

find_analyses function may need ReferenceAnalysis and DuplicateAnalysis handling


Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant