Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Analysis Service result options with non numeric values fails/not accepted #1956

Open
Ruhanga opened this issue Apr 4, 2022 · 1 comment

Comments

@Ruhanga
Copy link

Ruhanga commented Apr 4, 2022

Description

Currently Result option values are only expected as floatable. For reference purposes, It'd be great that the Result Option values just like the result interim field values, acceptuids for their value. This would be especially handy in an integration environment where such predefined values would be identifiable with a non numeric value/Id i.e. uid.

Observed behaviour

Results Options widget does not accept non-numeric values for it's options.

Expected behaviour

Results Options fields should accept non-numeric values(at-least valid uids) for it's options just like the the Interim Results fields do.

@Ruhanga
Copy link
Author

Ruhanga commented Apr 4, 2022

Hi @xispa, would you have any thoughts on this issue and a proposed fix: #1957? Thank you.
cc @ramonski

Ruhanga added a commit to Ruhanga/senaite.core that referenced this issue Apr 7, 2022
Ruhanga added a commit to Ruhanga/senaite.core that referenced this issue Apr 7, 2022
Ruhanga added a commit to Ruhanga/senaite.core that referenced this issue Apr 8, 2022
Related issues:
   * EIP-86: SENAITE routes to handle coded test results
             https://issues.openmrs.org/browse/EIP-86
   * senaite.core issue - Result Value to not be fixed to integer but should also support uids
             senaite#1956
rbuisson pushed a commit to mekomsolutions/senaite.core that referenced this issue Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant