Fix in VoID source selection #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antru6 from what I see in the PR, the old behaviour was to include all datasets that matched any one of the elements of the query pattern, and the new, stricter, behaviour is to include all datasets that match all non-null elements of the query pattern. Please confirm or correct. |
|
Yes, correct. I changed this because according to the Sevod paper (@PROFLES17) the triple _:d subjectRegexPattern "/pattern/" means that all subjects of the dataset _:d match the regex pattern /pattern/ (same with objectRegexPattern). |
|
@antru6 Please create a new PR targeting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes in VoID source selector to fix #54