Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In React 16.9.x & up, Console warnings about componentDidMount & willReceiveProps, require UNSAFE_ prefix. #58

Open
nypinstripes opened this issue Aug 20, 2019 · 1 comment · May be fixed by #59

Comments

@nypinstripes
Copy link

Hey, @prrashi @emilcieslar @selvagsz @umanghome @SCasarotto

As of React 16.9.x it seems the authors are beginning their transition to a full hooks or hooks preferred component strategy. This latest change requires that all componentWillMount, componentWillReceiveProps & componentWillUpdate calls, including those within bundle dependency packages, be prefixed with the UNSAFE_ prefix in order to dismiss the below console warnings. Of which, in my latest app where I'm using power-select I get about 4 per instance. I'd love to continue using power-select for all my select & typeahead needs, but have some stricter demands from my colleagues on console warnings, if you would kindly check into this, I'd be most appreciative. Thanks

Btw been a fan of your (highly flexible) library for a couple years now and have used it in just about every react project I've worked on.

Screen Shot 2019-08-20 at 10 49 12 AM

https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

@selvagsz
Copy link
Owner

selvagsz commented Aug 25, 2019

@nypinstripes Appreciate your nice words. I'd go ahead with running the codemod to resolve the deprecation notices as a short term fix

I've plans to rewrite this package to use the react hooks

@selvagsz selvagsz reopened this Aug 25, 2019
@selvagsz selvagsz linked a pull request Aug 26, 2019 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants