Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Riding Entities through Portal #306

Open
ZorudaRinku opened this issue Dec 12, 2021 · 4 comments
Open

Rework Riding Entities through Portal #306

ZorudaRinku opened this issue Dec 12, 2021 · 4 comments

Comments

@ZorudaRinku
Copy link

Old issue: #135

Start of convo: https://discord.com/channels/168282484037910528/249757652664582161/919122169705938974

Reopening a new issue for the rework of riding entities through portals and coming out the other side with full NBT data.
If the same camera smoothness issue comes back with the reintegration of this feature it might be worth considering just placing the player and the entity next to each other on the other side. Allowing the player to transfer the entity but with small negligible fact that they'll have to remount on the other side.

@sekwah41
Copy link
Owner

sekwah41 commented Dec 14, 2021

Both this task and #305 may be solved with the same main code, however, this will mostly focus on cross-world teleportation while the other task will focus on per world short and long-range teleportation.

We will also want to check that the entities are possibly not controlled by another plugin, because if we kill and re-create them they may end up with broken logic. E.g. on servers like Hypixel where you can have temporary rideable pets, it may be abusable to create an animal spawner.

@NamiUni
Copy link

NamiUni commented Jan 9, 2022

Can this feature be made to work cross server?
I have a lot of users on my server who want to move their horses to another server.
If it were possible that would be so great!

@sekwah41
Copy link
Owner

sekwah41 commented Jan 10, 2022

Sadly that's quite a lot different, as we would have to serialise the entities and do quite a lot more. Though I can take a look into it.

@NamiUni
Copy link

NamiUni commented Jan 11, 2022

Oh, that's true.
I hope I can contribute to this feature when I have time. Thank you for answering my ramblings!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants