Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove entries from "Add new" in DataHub #1783

Closed
floradanna opened this issue Mar 11, 2024 · 1 comment · Fixed by #1872
Closed

Remove entries from "Add new" in DataHub #1783

floradanna opened this issue Mar 11, 2024 · 1 comment · Fixed by #1872
Assignees
Labels
datahub belgiumHub project
Milestone

Comments

@floradanna
Copy link
Collaborator

floradanna commented Mar 11, 2024

In DataHub, we do not (yet) wish to make use of some entities such as strain and model. These entries have been removed (disabled, hidden) from Browse and Create, but they are still accessible via "Add new".

Fix: remove not needed entries from "add new", for consistency with Browse and Create options in DataHub

Image

@floradanna floradanna added the datahub belgiumHub project label Mar 11, 2024
@kdp-cloud kdp-cloud added this to the 1.15.1 milestone May 8, 2024
@kdp-cloud
Copy link
Collaborator

The Add new button adds a button to the drop-down for each enabled feature.
So disabling models, removes the 'Add new Model' option from the drop-down.
Strains on the other hand does not have a configurable setting, which makes it always added to the drop-down.

To solve this, a new setting should be added which adopts the same value as the organisms_enabled config.
So when organisms in enabled, 'Add new Strain' will show and when organisms is disabled, 'Add new Strain' is not add to the drop-down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datahub belgiumHub project
Projects
Status: Merged
Development

Successfully merging a pull request may close this issue.

2 participants