Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test DynamicTableHelper #1870

Closed
kdp-cloud opened this issue May 8, 2024 · 0 comments
Closed

Fix failing test DynamicTableHelper #1870

kdp-cloud opened this issue May 8, 2024 · 0 comments
Assignees
Labels
Projects
Milestone

Comments

@kdp-cloud
Copy link
Collaborator

This tests fails often randomly:

DynamicTableHelperTest#test_Should_return_the_dynamic_table_columns_and_rows [/home/runner/work/seek/seek/test/unit/helpers/dynamic_table_helper_test.rb:51]
Minitest::Assertion: Expected: false
  Actual: true

The issue is probably the usage of the ISA tag fixtures. It would be best to replace them with factories instead.

@kdp-cloud kdp-cloud added the bug label May 8, 2024
@kdp-cloud kdp-cloud added this to the 1.15.1 milestone May 8, 2024
@kdp-cloud kdp-cloud self-assigned this May 8, 2024
@kdp-cloud kdp-cloud added this to To do in SEEK 1.15.x via automation May 8, 2024
SEEK 1.15.x automation moved this from To do to Done May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

No branches or pull requests

1 participant