Issue 1783 fix add new button #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuzart
requested changes
May 9, 2024
There was a problem hiding this comment.
A new config setting probably isn't appropriate, since strains is dependant on organisms.
Just add a strains_enabled method to the Seek::Config that returns organism_enabled .
There are other cases here: https://github.com/seek4science/seek/blob/main/lib/seek/config.rb#L323
e.g how templates_enabled is dependant on isa_json_complaint_enabled
kdp-cloud
force-pushed
the
issue_1783_fix_add_new_button
branch
from
db4698f
to
cf67cea
Compare
stuzart
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Add new drop-down menu hides 'Add new Strain' when
organisms_enabledis set to false. Fixes #1783